From 1008d3616e5359854ab1b8eed7adf71efb34e6f1 Mon Sep 17 00:00:00 2001
From: luwenpeng <luwenpeng@geedgenetworks.com>
Date: Thu, 26 Oct 2023 18:54:05 +0800
Subject: [PATCH] =?UTF-8?q?hasp=5Fmonitor=E5=92=8Chasp=5Fverify=E7=A8=8B?=
 =?UTF-8?q?=E5=BA=8F=E9=80=80=E5=87=BA=E5=89=8D=E4=B8=8D=E5=86=8D=E6=89=A7?=
 =?UTF-8?q?=E8=A1=8Cshm=5Funlink();=20=E4=B8=BAhasp=5Fverify=E8=AE=BE?=
 =?UTF-8?q?=E7=BD=AE=E7=BA=BF=E7=A8=8B=E5=90=8D"hasp"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 platform/src/hasp_verify.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/platform/src/hasp_verify.c b/platform/src/hasp_verify.c
index 67ba4e1..05523c3 100644
--- a/platform/src/hasp_verify.c
+++ b/platform/src/hasp_verify.c
@@ -7,6 +7,7 @@
 #include <unistd.h>
 #include <pthread.h>
 #include <sys/mman.h>
+#include <sys/prctl.h>
 
 #include "hasp_api.h"
 #include "hasp_vcode.h"
@@ -49,11 +50,13 @@ static void signal_handler(int signo)
     if (signo == SIGUSR1)
     {
         LOG_LEVEL_SET_DEBUG();
+        LOG_INFO("hasp_monitor: recv SIGUSR1");
     }
 
     if (signo == SIGUSR2)
     {
         LOG_LEVEL_SET_INFO();
+        LOG_INFO("hasp_monitor: recv SIGUSR2");
     }
 
     if (signo == SIGINT)
@@ -634,11 +637,11 @@ void hasp_monitor(uint64_t feature_id, uint64_t interval)
     munmap(shm, sizeof(struct shm_data));
 
     /*
-     * Unlink the shared memory object.
-     * Even if the peer process is still using the object, this is okay.
-     * The object will be removed only after all open references are closed.
+     * hasp_monitor 退出时如果执行了 shm_unlink(), shm_key 文件会被释放
+     * hasp_monitor 重启后会创建新的 shm_key 文件，而运行中的 firewall 则使用的是与旧的 shm_key 文件相关的共享内存
+     * 所以此处不执行 shm_unlink()
      */
-    shm_unlink(shm_key);
+    // shm_unlink(shm_key);
 
     return;
 }
@@ -656,6 +659,10 @@ static void *hasp_verify_cycle(void *arg)
 
     LOG_INFO("hasp_verify: Expect Feature ID: %ld", expect_feature_id);
 
+    char thread_name[16];
+    snprintf(thread_name, sizeof(thread_name), "hasp");
+    prctl(PR_SET_NAME, (unsigned long long)thread_name, NULL, NULL, NULL);
+
     signal(SIGUSR1, signal_handler);
     signal(SIGUSR2, signal_handler);
 
@@ -711,22 +718,13 @@ error_out:
      * Updates to the mapping are visible to other processes that map this file, and are carried through to the underlying file.
      * The file may not actually be updated until msync(2) or munmap() is called.
      */
-
     if (addr)
     {
         munmap(addr, size);
         addr = NULL;
     }
 
-    /*
-     * Unlink the shared memory object.
-     * Even if the peer process is still using the object, this is okay.
-     * The object will be removed only after all open references are closed.
-     */
-    if (fd > 0)
-    {
-        shm_unlink(shm_key);
-    }
+    // 此处不执行 shm_unlink(shm_key); 避免 firewall 退出时删除 shm_key 文件
 
     free(arg);
     arg = NULL;