From b2af6cdad85d396b29106a3ebbc5bcf2990be98c Mon Sep 17 00:00:00 2001
From: chaoc <liangchao@geedgenetworks.com>
Date: Thu, 3 Aug 2023 17:48:35 +0800
Subject: [PATCH] perf(error): optimize cond

---
 .../zdjizhi/flink/voip/error/ErrorHandler.java  | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/main/java/com/zdjizhi/flink/voip/error/ErrorHandler.java b/src/main/java/com/zdjizhi/flink/voip/error/ErrorHandler.java
index 995da1e..3269947 100644
--- a/src/main/java/com/zdjizhi/flink/voip/error/ErrorHandler.java
+++ b/src/main/java/com/zdjizhi/flink/voip/error/ErrorHandler.java
@@ -5,6 +5,8 @@ import com.zdjizhi.flink.voip.conf.FusionConfiguration;
 import com.zdjizhi.flink.voip.formats.JsonNodeSerializationSchema;
 import com.zdjizhi.flink.voip.records.Record;
 import com.zdjizhi.flink.voip.records.SIPRecord;
+import com.zdjizhi.flink.voip.records.SchemaType;
+import com.zdjizhi.flink.voip.records.StreamDir;
 import com.zdjizhi.utils.IPUtil;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.flink.configuration.Configuration;
@@ -105,8 +107,21 @@ class MeaninglessAddressProcessFunction extends ProcessFunction<ObjectNode, Obje
                 || IPUtil.internalIp(sipRecord.getOriginatorSdpConnectIp());
         boolean cond3 = !IPUtil.isIPAddress(sipRecord.getResponderSdpConnectIp())
                 || IPUtil.internalIp(sipRecord.getResponderSdpConnectIp());
+        boolean cond4 = IPUtil.isIPAddress(sipRecord.getOriginatorSdpConnectIp())
+                || IPUtil.isIPAddress(sipRecord.getResponderSdpConnectIp());
+        boolean cond5 = SchemaType.SIP.getValue().equalsIgnoreCase(sipRecord.getSchemaType());
+        boolean cond6 = StreamDir.DOUBLE.getValue() == sipRecord.getStreamDir() &&
+                IPUtil.internalIp(sipRecord.getResponderSdpConnectIp()) &&
+                IPUtil.internalIp(sipRecord.getOriginatorSdpConnectIp());
 
-        if (cond1 && cond2 && cond3) {
+        // Both client and server addresses in the data are valid.
+        if (cond1 && (
+                // The address in the SIP one-way stream is valid and not an internal network address.
+                cond2 && cond3 && cond4 && cond5
+                        // The coordinating addresses in the SIP double directional stream are valid
+                        // and not internal network addresses.
+                        || cond5 && cond6
+                        || !cond5)) {
             out.collect(obj);
         } else {
             // Output invalid records to the invalid output tag